⚠ In case you've missed it, we have migrated to our new website, with a brand new forum. For more details about the migration you can read our blog post for website migration. This is an archived forum. ⚠

  •     

profile picture

What's the best way to update GroceryCrud code/languages files

Started by Benoit VRIGNAUD, 02 March 2015 - 08:57 AM


Benoit VRIGNAUD

Benoit VRIGNAUD
  • profile picture
  • Member

Posted 02 March 2015 - 08:57 AM

Hello everybody,

I'm working on an easy update of GroceryCRUD : Grocery_CRUD.php->_load_date_format() (line 4000)
@todo ui_day, ui_month, ui_year has to be lang strings

so I replace :

list($ui_day, $ui_month, $ui_year) = array('dd','mm','yyyy');

by

list($ui_day, $ui_month, $ui_year) = array($this->l('ui_day'), $this->l('ui_month'), $this->l('ui_year'));

And I add this new lines

english.php

$lang['ui_day'] = 'dd';
$lang['ui_month'] = 'mm';
$lang['ui_year'] = 'yyyy';

french.php

$lang['ui_day'] = 'jj';
$lang['ui_month'] = 'mm';
$lang['ui_year'] = 'aaaa';

Everything is Ok I'm ready to make the pull-request on github.
My only question is about the good way ...

Does I have to add this new language line to the others files languages ?
And if yes, how ? Does I have to copy the english one ?


Notes : You can send me your languages, I will add them.

Thanks